This repository was archived by the owner on May 15, 2025. It is now read-only.
Minor fixes in instructions for deploying dev k8s env #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
elevran
commented
Apr 24, 2025
elevran
commented
- notes regarding use of existing images
- fixed wrong service name
elevran
changed the title
|
Probably we would want to change the Makefile clean target for k8s to remove resources and NOT delete the namespace (unless created by the user). |
- notes regarding use of existing images - fixed wrong service name Signed-off-by: Etai Lev Ran <[email protected]>
|
@shaneutt PTAL |
shaneutt
approved these changes
Apr 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.